Skip to content

fix: add Flipper deprecation warning - #1655

Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/deprecate-flipper
Oct 24, 2023
Merged

fix: add Flipper deprecation warning#1655
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/deprecate-flipper

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Oct 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Flipper has been removed upstream. We will also be removing it from 3.0.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Verify that there are no warnings when running:

cd example/android
./gradlew clean  # No Flipper warnings here
cd ..
pod install --project-directory=ios  # No Flipper warnings here

Enable Flipper:

diff --git a/example/android/gradle.properties b/example/android/gradle.properties
index a951019..feed9af 100644
--- a/example/android/gradle.properties
+++ b/example/android/gradle.properties
@@ -29,7 +29,7 @@ android.enableJetifier=true

 # Version of Flipper to use with React Native. Default value is whatever React
 # Native defaults to. To disable Flipper, set it to `false`.
-#FLIPPER_VERSION=0.182.0
+FLIPPER_VERSION=0.182.0

 # Enable Fabric at runtime.
 #USE_FABRIC=1
diff --git a/example/ios/Podfile b/example/ios/Podfile
index 245fc9a..be8485f 100644
--- a/example/ios/Podfile
+++ b/example/ios/Podfile
@@ -2,7 +2,7 @@ require_relative '../node_modules/react-native-test-app/test_app'

 workspace 'Example.xcworkspace'

-use_flipper! false unless ENV['ENABLE_FLIPPER']
+use_flipper!

 options = {
   :fabric_enabled => false,

With Flipper enabled, we should see warnings:

cd android
./gradlew clean  # Flipper deprecation warning
cd ..
pod install --project-directory=ios  # Flipper deprecation warning

Finally, verify that react-native@nightly builds: https://github.com/microsoft/react-native-test-app/actions/runs/6556025689/job/17805367241

@github-actions github-actions Bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS labels Oct 18, 2023
@tido64 Tommy Nguyen (tido64) mentioned this pull request Oct 18, 2023
Closed
31 of 33 tasks
@kelset Lorenzo Sciandra (kelset) mentioned this pull request Oct 23, 2023
Merged
2 of 4 tasks
kelset
Lorenzo Sciandra (kelset) approved these changes Oct 23, 2023
View reviewed changes

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ended up hitting an issue which turns out to be a real thing #1669 but overall :shipit:

@tido64
Tommy Nguyen (tido64) merged commit b4e7767 into trunk Oct 24, 2023
@tido64
Tommy Nguyen (tido64) deleted the tido/deprecate-flipper branch October 24, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arazabishov Araz Abishov (arazabishov) Awaiting requested review from arazabishov
@sweggersen Sam Mathias Weggersen (sweggersen) Awaiting requested review from sweggersen
1 more reviewer
@kelset Lorenzo Sciandra (kelset) kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @kelset